Added missing ticket failure test

lib/omniauth/strategies/cas.rb

@@ -21,10 +21,14 @@ module OmniAuth
         @configuration = Configuration.new( @options )
       end
 
-      # def callback_phase
-      #   ap "CALLBACK PHASE"
-      #   super
-      # end
+      def callback_phase
+        ticket = request.params['ticket']
+        return fail!(:no_ticket, 'No CAS Ticket') unless ticket
+        # validator = ServiceTicketValidator.new(@configuration, callback_url, ticket)
+        # @user_info = validator.user_info
+        return fail!(:invalid_ticket, 'Invalid CAS Ticket') if @user_info.empty?
+        super
+      end
 
       # def request_call
       #   ap "REQUEST CALL"

spec/omniauth/strategies/cas_spec.rb

@@ -29,15 +29,18 @@ describe OmniAuth::Strategies::CAS, :type => :strategy do
     end
   end
 
-  # describe 'GET /auth/cas/callback without a ticket' do
-  #   before do
-  #     # get '/auth/cas/callback'
-  #   end
-  #   it 'should fail'# do
-  #     # last_response.should be_redirect
-  #     # last_response.headers['Location'].should =~ /no_ticket/
-  #   # end
-  # end
+  describe 'GET /auth/cas/callback without a ticket' do
+    before do
+      get '/auth/cas/callback'
+    end
+
+    subject { last_response }
+
+    it { should be_redirect }
+    it "should have a failure message" do
+      subject.headers['Location'].should =~ /message=no_ticket/
+    end
+  end
 
   # describe 'GET /auth/cas/callback with an invalid ticket' do
   #   before do